Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support of package_bundled_index.json and builtin_tools_versions.txt #2424

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Drop support of package_bundled_index.json and builtin_tools_versions.txt #2424

merged 4 commits into from
Jan 2, 2024

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Nov 14, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

After an internal discussion, we have decided that after the refactoring of the legacy builder, is impossible to maintain the old arduino-builder used by the Java IDE.
In the spirit of the upcoming v1.0.0 we're dropping the support of: package_bundled_index.json and builtin_tools_versions.txt for good as the Java IDE is deprecated trying to maintain this legacy part doesn't bring any relevant value.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini linked an issue Nov 14, 2023 that may be closed by this pull request
Drop support of package_bundled_index.json and builtin_tools_versions.txt #2423
Closed
3 tasks
@alessio-perugini alessio-perugini self-assigned this Nov 14, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1911448) 68.46% compared to head (77c8204) 68.78%.

Files Patch % Lines
...al/arduino/cores/packagemanager/package_manager.go 44.44% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2424      +/-   ##
==========================================
+ Coverage   68.46%   68.78%   +0.31%     
==========================================
  Files         204      204              
  Lines       20553    20446     -107     
==========================================
- Hits        14071    14063       -8     
+ Misses       5332     5242      -90     
+ Partials     1150     1141       -9
Flag Coverage Δ
unit 68.78% <58.33%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini marked this pull request as ready for review November 14, 2023 15:42
umbynos
umbynos approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 16, 2023
@alessio-perugini alessio-perugini added the status: blocked Progress on this prevented by an external cause label Nov 21, 2023
@alessio-perugini
Copy link
Contributor Author

alessio-perugini commented Nov 21, 2023 •
edited
Loading

@per1234 do you know if those are used in the real world? it was used in the java IDE but we are planning to remove the support for those.
https://arduino.github.io/arduino-cli/0.35/configuration/
directories:
- builtin.libraries - the libraries in this directory will be available to all platforms without the need for the user to install them, but with the lowest priority over other installed libraries with the same name, it's the equivalent of the Arduino IDE's bundled libraries directory.

  • builtin.tools - it's a list of directories of tools that will be available to all platforms without the need for the user to install them, it's the equivalent of the Arduino IDE 1.x bundled tools directory.

@alessio-perugini alessio-perugini marked this pull request as draft December 13, 2023 09:34
@alessio-perugini alessio-perugini force-pushed the 2423-drop-support-of-package_bundled_indexjson-and-builtin_tools_versionstxt branch 5 times, most recently from df92d88 to c40b060 Compare December 19, 2023 09:18
@alessio-perugini alessio-perugini marked this pull request as ready for review December 19, 2023 09:30
@alessio-perugini alessio-perugini force-pushed the 2423-drop-support-of-package_bundled_indexjson-and-builtin_tools_versionstxt branch from bce1684 to 4911d96 Compare December 22, 2023 14:26
@alessio-perugini alessio-perugini force-pushed the 2423-drop-support-of-package_bundled_indexjson-and-builtin_tools_versionstxt branch from 4911d96 to 77c8204 Compare January 2, 2024 10:08
@alessio-perugini alessio-perugini merged commit 07cf265 into master Jan 2, 2024
207 checks passed
@alessio-perugini alessio-perugini deleted the 2423-drop-support-of-package_bundled_indexjson-and-builtin_tools_versionstxt branch January 2, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

@cmaglie cmaglie cmaglie approved these changes

@MatteoPologruto MatteoPologruto Awaiting requested review from MatteoPologruto

@per1234 per1234 Awaiting requested review from per1234

Assignees

@alessio-perugini alessio-perugini

Labels
status: blocked Progress on this prevented by an external cause topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support of package_bundled_index.json and builtin_tools_versions.txt
3 participants
@alessio-perugini @cmaglie @umbynos